[
https://issues.apache.org/jira/browse/MESOS-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546925#comment-14546925
]
Greg Mann edited comment on MESOS-994 at 5/17/15 5:04 AM:
----------------------------------------------------------
Review requests submitted. ReviewBot didn't like one of the dependencies
attached to Ben's original Review #13978, so I added the refactoring of
os::getenv into the first of the patches below.
We have updates to callers in /src, libprocess, and stout, respectively:
https://reviews.apache.org/r/34317/
https://reviews.apache.org/r/34318/
https://reviews.apache.org/r/34319/
was (Author: greggomann):
Review requests submitted. We have Ben's original patch for os::getenv():
https://reviews.apache.org/r/13978/
along with changes to callers in /src, libprocess, and stout, respectively:
https://reviews.apache.org/r/34317/
https://reviews.apache.org/r/34318/
https://reviews.apache.org/r/34319/
> Add an Option<string> os::getenv() to stout
> -------------------------------------------
>
> Key: MESOS-994
> URL: https://issues.apache.org/jira/browse/MESOS-994
> Project: Mesos
> Issue Type: Improvement
> Components: stout, technical debt
> Reporter: Ian Downes
> Assignee: Greg Mann
> Labels: newbie
>
> This would replace the common pattern of:
> Option<string> = os::hasenv() ? Option<string>(os::getenv()) : None()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
