[
https://issues.apache.org/jira/browse/MESOS-2800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578443#comment-14578443
]
Joris Van Remoortere commented on MESOS-2800:
---------------------------------------------
My understanding is that we aim for only having 1 way to express something
unless absolutely necessary. That would suggest only having 1 function.
I think without looking at the comments at the function declaration site, it is
not directly obvious what this function should do. Therefore, unless someone
has a good reason not to, I think it is valuable to rename this function to
{{getOrElse}} since the burden is currently still low.
Feel free to add me as a reviewer for your patch :-)
> Rename Option<T>::get(const T& _t) to getOrElse() and refactor the original
> function
> ------------------------------------------------------------------------------------
>
> Key: MESOS-2800
> URL: https://issues.apache.org/jira/browse/MESOS-2800
> Project: Mesos
> Issue Type: Improvement
> Components: stout
> Reporter: Mark Wang
> Assignee: Mark Wang
> Priority: Minor
> Labels: newbie
>
> As suggested, if we want to change the name then we should refactor the
> original function as opposed to having 2 copies.
> If we did have 2 versions of the same function, would it make more sense to
> delegate one of them to the other.
> As of today, there is only one file need to be refactor:
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp at line 151, 161
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
