[
https://issues.apache.org/jira/browse/MESOS-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589142#comment-14589142
]
Benjamin Mahler commented on MESOS-1648:
----------------------------------------
Yes, looks like a duplicate, mind closing one and updating the descriptions?
I'd suggest breaking the patches up. As a first approach, we can add this to
the common logging flags, and write the file during logging initialization. I'd
imagine this would be good enough for a lot of people.
Locking and removal of the file would be good to tackle in further patches
({{finalize}} does not execute in most production setups, rather, the slave
gets a signal, or calls exit). I'd imagine we may want to {{unlink}} from
within an {{atexit}} handler and our common [signal
handler|https://github.com/apache/mesos/blob/02160a1ceb7d54b851b623e669e6a648be5471c1/src/logging/logging.cpp#L74]),
curious what other projects do as well.
> mesos-slave and mesos-master should have a --pidfile option
> -----------------------------------------------------------
>
> Key: MESOS-1648
> URL: https://issues.apache.org/jira/browse/MESOS-1648
> Project: Mesos
> Issue Type: Improvement
> Components: master, slave
> Reporter: Tobias Weingartner
> Assignee: Greg Mann
> Labels: newbie, twitter
>
> Right now we use a number of wrapper scripts to try and keep up a
> {{/var/run/mesos/mesos-slave.pid}} in order to be able to monitor the
> process. It would be nice if this extra (somewhat fragile) wrapper was not
> necessary. Having a {{--pidfile}} option would eliminate some of this pain.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
