[ 
https://issues.apache.org/jira/browse/MESOS-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599886#comment-14599886
 ] 

Niklas Quarfot Nielsen commented on MESOS-2637:
-----------------------------------------------

Hi [~lackita] - Did you get to look at this?

I will be out for the next two weeks from tomorrow.
If you are planning on getting reviews/feedback in the mean time - can you ping 
one of the other committers?

Thanks!
Niklas

> Consolidate 'foo', 'bar', ... string constants in test and example code
> -----------------------------------------------------------------------
>
>                 Key: MESOS-2637
>                 URL: https://issues.apache.org/jira/browse/MESOS-2637
>             Project: Mesos
>          Issue Type: Bug
>          Components: technical debt
>            Reporter: Niklas Quarfot Nielsen
>            Assignee: Colin Williams
>
> We are using 'foo', 'bar', ... string constants and pairs in 
> src/tests/master_tests.cpp, src/tests/slave_tests.cpp, 
> src/tests/hook_tests.cpp and src/examples/test_hook_module.cpp for label and 
> hooks tests. These values should be stored in local variables to avoid the 
> possibility of assignment getting out of sync with checking for that same 
> value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to