[ 
https://issues.apache.org/jira/browse/MESOS-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602795#comment-14602795
 ] 

Joerg Schad commented on MESOS-2944:
------------------------------------

https://reviews.apache.org/r/35920/

> Use of EXPECT in test and relying on the checked condition afterwards.
> ----------------------------------------------------------------------
>
>                 Key: MESOS-2944
>                 URL: https://issues.apache.org/jira/browse/MESOS-2944
>             Project: Mesos
>          Issue Type: Bug
>          Components: test
>            Reporter: Joerg Schad
>            Assignee: Joerg Schad
>            Priority: Minor
>              Labels: mesosphere
>
> In docker_containerizer_test we have the following pattern.
> ~~~
> EXPECT_NE(0u, offers.get().size());
>  const Offer& offer = offers.get()[0];
> ~~~
> As we rely on the value afterwards we should use ASSERT_NE instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to