[
https://issues.apache.org/jira/browse/MESOS-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625750#comment-14625750
]
gyliu commented on MESOS-3040:
------------------------------
The step 7 in submitting a patch is:
Make your changes to the code (using whatever IDE/editor you choose) to
actually fix the bug or implement the feature.
Before beginning, please read the Mesos C++ Style Guide. It is recommended
to use the git pre-commit hook (support/hooks/pre-commit) to automatically
check for style errors. See the hook script for instructions to enable it.
Most of your changes will probably be to files inside of BASE_MESOS_DIR
To build, we recommend that you don’t build inside of the src directory. We
recommend you do the following:
From inside of the root Mesos directory: mkdir build && cd build
../configure
make
Now all of the files generated by the build process will be contained
in the build directory you created, instead of being spread throughout the src
directory, which is a bit messier. This is both cleaner, and makes it easy to
clean up if you want to get rid of the files generated by configure and make.
I.e. You can reset your build process without risking changes you made in the
src directory, by simply deleting the build directory, and creating a new one.
Make sure all of your test cases now pass.
The build instructions in getting start is:
# Change working directory.
$ cd mesos
# Bootstrap (Only required if building from git repository).
$ ./bootstrap
# Configure and build.
$ mkdir build
$ cd build
$ ../configure
$ make
IMHO, the getting started can give some command to enable one can get a quick
start, but the submitting a patch should add more detail for what the command
does and why we want to do that.
> Update submitting-a-patch.md
> ----------------------------
>
> Key: MESOS-3040
> URL: https://issues.apache.org/jira/browse/MESOS-3040
> Project: Mesos
> Issue Type: Documentation
> Components: documentation
> Affects Versions: 1.0.0
> Reporter: gyliu
> Assignee: gyliu
> Fix For: 1.0.0
>
>
> When developer is using git to clone the mesos source code and want to build,
> s/he need to run ./bootstrap first to generate some files such as configure,
> .gitignore etc. But the document do not including such instructions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
