[
https://issues.apache.org/jira/browse/MESOS-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646489#comment-14646489
]
Anand Mazumdar edited comment on MESOS-3169 at 7/29/15 5:48 PM:
----------------------------------------------------------------
The `FrameworkErrorMessage` generated from `failoverFramework` is sent to the
old scheduler. So , we should go ahead with updating the framework info
correctly for that case as we are doing now.
The only point of contention hence is this:
{code}else if (from != framework->pid); {code}
I guess the easiest fix would be to update the info at the end of the function
rather then at the beginning unless I am missing something ?
was (Author: anandmazumdar):
The `FrameworkErrorMessage` generated from `failoverFramework` is sent to the
old scheduler. So , we should go ahead with updating the framework info
correctly for that case as we are doing now.
The only point of contention hence is this:
{code }else if (from != framework->pid); {code}
I guess the easiest fix would be to update the info at the end of the function
rather then at the beginning unless I am missing something ?
> FrameworkInfo should only be updated if the re-registration is valid
> --------------------------------------------------------------------
>
> Key: MESOS-3169
> URL: https://issues.apache.org/jira/browse/MESOS-3169
> Project: Mesos
> Issue Type: Bug
> Components: master
> Affects Versions: 0.23.0
> Reporter: Joris Van Remoortere
> Labels: framework, master, mesosphere
>
> See Ben Mahler's comment in https://reviews.apache.org/r/32961/
> FrameworkInfo should not be updated if the re-registration is invalid. This
> can happen in a few cases under the branching logic, so this requires some
> refactoring.
> Notice that a {code}FrameworkErrorMessage{code} can be generated both inside
> {code}else if (from != framework->pid){code} as well as from inside
> {code}failoverFramework(framework, from);{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
