[ 
https://issues.apache.org/jira/browse/MESOS-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647480#comment-14647480
 ] 

Bernd Mathiske edited comment on MESOS-3174 at 7/30/15 11:12 AM:
-----------------------------------------------------------------

The piece of code in question is in launcher/fetcher.cpp263 and reads:

~~~
    if (extracted.isError()) {
      return Error(extracted.error());
    } else {
      LOG(WARNING) << "Copying instead of extracting resource from URI with "
                   << "'extract' flag, because it does not seem to be an "
                   << "archive: " << uri.value();
    }
~~~
This could be the fix:

~~~
    if (extracted.isError()) {
      return Error(extracted.error());
    } else if (!extracted.get()) {
      LOG(WARNING) << "Copying instead of extracting resource from URI with "
                   << "'extract' flag, because it does not seem to be an "
                   << "archive: " << uri.value();
    }
~~~


was (Author: bernd-mesos):
The piece of code in question is in launcher/fetcher.cpp263 and reads:

<code>
    if (extracted.isError()) {
      return Error(extracted.error());
    } else {
      LOG(WARNING) << "Copying instead of extracting resource from URI with "
                   << "'extract' flag, because it does not seem to be an "
                   << "archive: " << uri.value();
    }
<code>

This could be the fix:

<code>
    if (extracted.isError()) {
      return Error(extracted.error());
    } else if (!extracted.get()) {
      LOG(WARNING) << "Copying instead of extracting resource from URI with "
                   << "'extract' flag, because it does not seem to be an "
                   << "archive: " << uri.value();
    }
<code>


> Fetcher logs erroneous message when successfully extracting an archive
> ----------------------------------------------------------------------
>
>                 Key: MESOS-3174
>                 URL: https://issues.apache.org/jira/browse/MESOS-3174
>             Project: Mesos
>          Issue Type: Bug
>          Components: fetcher
>    Affects Versions: 0.23.0
>            Reporter: Bernd Mathiske
>            Priority: Minor
>
> When fetching an asset while not using the cache, the fetcher may erroneously 
> report this: "Copying instead of extracting resource from URI with 'extract' 
> flag, because it does not seem to be an archive: ".
> This message appears in the stderr log in the sandbox no matter whether 
> extraction succeeded or not. It should be absent after successful extraction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to