[ 
https://issues.apache.org/jira/browse/MESOS-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721399#comment-14721399
 ] 

Benjamin Mahler commented on MESOS-2986:
----------------------------------------

I was just suggesting that if we want to fix this, we avoid pushing it into 
stout's Version class. Rather, we could have the docker code in mesos go from 
X.Y.Z.EXTRA -> X.Y.Z, for example, with a big comment saying why we do this for 
docker, and a pointer to the docker issue you opened about not following 
semver. Alternatively, if it turns out that {{x.y.z.extra.versions}} is a 
common practice, perhaps it is worth storing an arbitrary number of components 
in Version, rather than just semver's 3 (would be great to avoid this though!).

I didn't want to suggest we do nothing if this is a real problem for users :)

> Docker version output is not compatible with Mesos
> --------------------------------------------------
>
>                 Key: MESOS-2986
>                 URL: https://issues.apache.org/jira/browse/MESOS-2986
>             Project: Mesos
>          Issue Type: Bug
>          Components: docker
>            Reporter: Isabel Jimenez
>            Assignee: Isabel Jimenez
>              Labels: mesosphere
>             Fix For: 0.23.0
>
>         Attachments: MESOS-2986_0_22_1.patch
>
>
> We currently use docker version to get Docker version, in Docker master 
> branch and soon in Docker 1.8 [1] the output for this command changes. The 
> solution for now will be to use the unchanged docker --version output, in the 
> long term we should consider stop using the cli and use the API instead. 
> [1] https://github.com/docker/docker/pull/14047



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to