[ https://issues.apache.org/jira/browse/MESOS-3344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14736003#comment-14736003 ]
Guangya Liu commented on MESOS-3344: ------------------------------------ A patch is ready for review: https://reviews.apache.org/r/37968 > Add more comments for strings::internal::fmt > -------------------------------------------- > > Key: MESOS-3344 > URL: https://issues.apache.org/jira/browse/MESOS-3344 > Project: Mesos > Issue Type: Bug > Affects Versions: 0.25.0 > Reporter: Guangya Liu > Assignee: Guangya Liu > Fix For: 0.25.0 > > > There is a issue MESOS-1805 which want to change the const pass-by-value to > const reference for some functions, but it is not right, as for some cases, > this will cause some unexpected behavior. We can add more comments for those > part for why not using const reference to make code clear. -- This message was sent by Atlassian JIRA (v6.3.4#6332)