[ 
https://issues.apache.org/jira/browse/MESOS-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742332#comment-14742332
 ] 

Klaus Ma commented on MESOS-3340:
---------------------------------

I'm OK to prioritize command-line flags over environment variables; the code 
diff was updated accordingly.

My previous "description" is that: some user may want to use env to overwrite 
cli, for example, the slaves were started by {{--ip}}, but he want to overwrite 
it by env in {{.bashrc}}; because {{.bashrc}} is in shared directory and start 
scripts are deployed in production. I was thinking to ask Operator to configure 
cluster explicitly.


> Command-line flags should take precedence over OS Env variables
> ---------------------------------------------------------------
>
>                 Key: MESOS-3340
>                 URL: https://issues.apache.org/jira/browse/MESOS-3340
>             Project: Mesos
>          Issue Type: Improvement
>          Components: stout
>    Affects Versions: 0.24.0
>            Reporter: Marco Massenzio
>            Assignee: Klaus Ma
>              Labels: mesosphere, tech-debt
>
> Currently, it appears that re-defining a flag on the command-line that was 
> already defined via a OS Env var ({{MESOS_*}}) causes the Master to fail with 
> a not very helpful message.
> For example, if one has {{MESOS_QUORUM}} defined, this happens:
> {noformat}
> $ ./mesos-master --zk=zk://192.168.1.4/mesos --quorum=1 
> --hostname=192.168.1.4 --ip=192.168.1.4
> Duplicate flag 'quorum' on command line
> {noformat}
> which is not very helpful.
> Ideally, we would parse the flags with a "well-known" priority (command-line 
> first, environment last) - but at the very least, the error message should be 
> more helpful in explaining what the issue is.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to