[
https://issues.apache.org/jira/browse/MESOS-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cong Wang updated MESOS-3523:
-----------------------------
Description:
Our current cpplint hook can't catch the following coding style issues:
1. Two blank lines before public/private/protect, for example:
{noformat}
class foo{
public:
foo();
private:
int bar;
protect:
int biz;
};
{noformat}
2. Braces not in the same line when the definition is empty, for example,
{noformat}
class Foo {
private:
Foo()
{}
};
{noformat}
3. Comment line longer than 70 characters.
4. Initialization lists indention, for example
{noformat}
class Foo
{
Foo()
: bar(_bar)
{}
};
{noformat}
was:
Our current cpplint hook can't catch the following coding style issues:
1. Two blank lines before public/private/protect, for example:
{noformat}
class foo{
public:
foo();
private:
int bar;
protect:
int biz;
};
{noformat}
2. Braces not in the same line when the definition is empty, for example,
{noformat}
class Foo {
private:
Foo()
{}
};
{noformat}
3. Comment line longer than 70 characters.
> Teach cpplint to catch more coding style issues
> -----------------------------------------------
>
> Key: MESOS-3523
> URL: https://issues.apache.org/jira/browse/MESOS-3523
> Project: Mesos
> Issue Type: Improvement
> Reporter: Cong Wang
>
> Our current cpplint hook can't catch the following coding style issues:
> 1. Two blank lines before public/private/protect, for example:
> {noformat}
> class foo{
> public:
> foo();
> private:
> int bar;
> protect:
> int biz;
> };
> {noformat}
> 2. Braces not in the same line when the definition is empty, for example,
> {noformat}
> class Foo {
> private:
> Foo()
> {}
> };
> {noformat}
> 3. Comment line longer than 70 characters.
> 4. Initialization lists indention, for example
> {noformat}
> class Foo
> {
> Foo()
> : bar(_bar)
> {}
> };
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
