[
https://issues.apache.org/jira/browse/MESOS-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14944435#comment-14944435
]
Cong Wang commented on MESOS-3523:
----------------------------------
[~marco-mesos] Nice work! Since clang-format is already added into Mesos repo,
why it still can't catch coding style issues for me? I guess it is not
integrated into a git hook yet? I think we need this as soon as possible, in
case anyone wasting more time on coding styles...
Cc [~vinodkone] and [~jieyu]
> Teach cpplint to catch more coding style issues
> -----------------------------------------------
>
> Key: MESOS-3523
> URL: https://issues.apache.org/jira/browse/MESOS-3523
> Project: Mesos
> Issue Type: Improvement
> Reporter: Cong Wang
> Labels: mesosphere
>
> Our current cpplint hook can't catch the following coding style issues:
> 1. Two blank lines before public/private/protect, for example:
> {noformat}
> class foo{
> public:
> foo();
> private:
> int bar;
> protect:
> int biz;
> };
> {noformat}
> 2. Braces not in the same line when the definition is empty, for example,
> {noformat}
> class Foo {
> private:
> Foo()
> {}
> };
> {noformat}
> 3. Comment line longer than 70 characters.
> 4. Initialization lists indention, for example
> {noformat}
> class Foo
> {
> Foo()
> : bar(_bar)
> {}
> };
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
