[ 
https://issues.apache.org/jira/browse/MESOS-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947167#comment-14947167
 ] 

haosdent commented on MESOS-3599:
---------------------------------

[~ekesken] I totally agree with your cases are normal user cases for health 
check. In fact, we have two way to change our health check in docker executor:

* First way:
Add a option to health check protobuf, so use this option as a flag to 
determine should launch health check outside or inside. But change health  
check protobuf would let the protobuf more confusion. Suppose we have http 
check and tcp check in the future, should this field also works for them or not?

* Second way:
Drop current implemention and revert to old behaviour, if user want to call 
health check in the docker, use "docker exec" instead. But for make user more 
convenience to do operations for docker container, we could import a 
environment variable like "MESOS_CONTAINER_NAME". So you not need use a tricky 
way to get docker container name.

> COMMAND health checks with marathon running in slave context broken
> -------------------------------------------------------------------
>
>                 Key: MESOS-3599
>                 URL: https://issues.apache.org/jira/browse/MESOS-3599
>             Project: Mesos
>          Issue Type: Bug
>    Affects Versions: 0.23.0
>            Reporter: Erhan Kesken
>            Assignee: haosdent
>            Priority: Critical
>             Fix For: 0.23.1, 0.24.1, 0.25.0
>
>
> When deploying Mesos 0.23rc4 with latest Marathon 0.10.0 RC3 command health 
> check stop working. Rolling back to Mesos 0.22.1 fixes the problem.
> Containerizer is Docker.
> All packages are from official Mesosphere Ubuntu 14.04 sources.
> The issue must be analyzed further.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to