[ 
https://issues.apache.org/jira/browse/MESOS-3554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955398#comment-14955398
 ] 

Benjamin Mahler commented on MESOS-3554:
----------------------------------------

I don't think we can close this since the main issue behind the large 
re-compilation was that the allocator had leaked into a widespread dependency. 
Even with the patch applied, many changes to the allocator require touching the 
header since the entire class declaration is there. This means we still have 
large re-compiles, which is why I suggested focusing on removing the 
unnecessary dependencies :)

Thanks for doing that change, but IMHO we should close this after any change to 
the allocator (including the declaration) doesn't trigger a large re-compile. 
Sounds reasonable?

> Allocator changes trigger large re-compiles
> -------------------------------------------
>
>                 Key: MESOS-3554
>                 URL: https://issues.apache.org/jira/browse/MESOS-3554
>             Project: Mesos
>          Issue Type: Improvement
>          Components: allocation
>            Reporter: Joris Van Remoortere
>            Assignee: Joris Van Remoortere
>              Labels: mesosphere
>
> Due to the templatized nature of the allocator, even small changes trigger 
> large recompiles of the code-base. This make iterating on changes expensive 
> for developers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to