[
https://issues.apache.org/jira/browse/MESOS-2315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966347#comment-14966347
]
Adam B edited comment on MESOS-2315 at 10/21/15 7:13 AM:
---------------------------------------------------------
Sounds about right, but..
The first example "with old ContainerInfo" doesn't actually use the old
ContainerInfo. I don't remember the exact semantics for how various
containerizers used the options field ([~tillt] might), but you should probably
have something like:
{code}
CommandInfo::ContainerInfo containerInfo;
containerInfo.set_image("busybox");
task.mutable_command()->mutable_container()->CopyFrom(containerInfo);
{code}
Also, if you're going to use ContainerInfo::MesosInfo, you should probably set
the image, or at least add a volume. Otherwise, you're just getting the default
Mesos containerization behavior, which you get even without a ContainerInfo.
was (Author: adam-mesos):
Sounds about right, but..
The first example "with old ContainerInfo" doesn't actually use the old
ContainerInfo. I don't remember the exact semantics for how various
containerizers used the options field ([~tillt] might), but you should probably
have something like:
```
CommandInfo::ContainerInfo containerInfo;
containerInfo.set_image("busybox");
task.mutable_command()->mutable_container()->CopyFrom(containerInfo);
```
Also, if you're going to use ContainerInfo::MesosInfo, you should probably set
the image, or at least add a volume. Otherwise, you're just getting the default
Mesos containerization behavior, which you get even without a ContainerInfo.
> Deprecate / Remove CommandInfo::ContainerInfo
> ---------------------------------------------
>
> Key: MESOS-2315
> URL: https://issues.apache.org/jira/browse/MESOS-2315
> Project: Mesos
> Issue Type: Task
> Reporter: Ian Downes
> Assignee: Vaibhav Khanduja
> Priority: Minor
> Labels: mesosphere, newbie
>
> IIUC this has been deprecated and all current code (except
> examples/docker_no_executor_framework.cpp) uses the top-level ContainerInfo?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
