[
https://issues.apache.org/jira/browse/MESOS-2315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986736#comment-14986736
]
Adam B commented on MESOS-2315:
-------------------------------
Looks correct, but let's not refer to these as "old ContainerInfo" and "new
ContainerInfo", since the old one was only introduced in 0.19, and the "new"
one is already over a year old. Also, the namespace would help distinguish the
two. So instead, let's refer to the "deprecated (soon-to-be-removed)
CommandInfo::ContainerInfo", which is not to be confused with the "top-level
ContainerInfo included as a field in TaskInfo or ExecutorInfo".
And your opening paragraph/sentence could use some work. Start with the key
question and then follow with other relevant details. I'd think the following
would be sufficient:
"Is anybody still using the deprecated CommandInfo::ContainerInfo protobuf
message from Mesos 0.19? It was deprecated in Mesos 0.20 in favor of the
top-level ContainerInfo message used as a field in TaskInfo/ExecutorInfo. As
per MESOS-2315, we'd like to remove CommandInfo::ContainerInfo. Please verify
that you are using the correct ContainerInfo, and let us know if we can help
you switch."
You can include the additional clarification examples if you like, but the
first question is the most important part (in case people don't read the rest).
You can also end by evoking lazy consensus, "If nobody objects to this change
in the next 72 hours, we will move forward with removing the
CommandInfo::ContainerInfo message."
Send this to dev@ and user@, since not all framework devs hang out on dev@.
> Deprecate / Remove CommandInfo::ContainerInfo
> ---------------------------------------------
>
> Key: MESOS-2315
> URL: https://issues.apache.org/jira/browse/MESOS-2315
> Project: Mesos
> Issue Type: Task
> Reporter: Ian Downes
> Assignee: Vaibhav Khanduja
> Priority: Minor
> Labels: mesosphere, newbie
>
> IIUC this has been deprecated and all current code (except
> examples/docker_no_executor_framework.cpp) uses the top-level ContainerInfo?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
