[
https://issues.apache.org/jira/browse/MESOS-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Clemmer updated MESOS-3872:
--------------------------------
Description:
>From the comments:
# TODO(hausdorff): We have disabled colors for the diffs on Windows, as piping
them through `subprocess` causes us to emit ANSI escape codes, which the
command prompt doesn't recognize. Presumably we are being routed through some
TTY that causes git to not emit the colors using `cmd`'s color codes API (which
is entirely different from ANSI. See [1] for more information and MESOS-3872.
#
# [1]
http://stackoverflow.com/questions/5921556/in-git-bash-on-windows-7-colors-display-as-code-when-running-cucumber-or-rspec
> Investigate adding color to `support/post-reviews.py` on Windows
> ----------------------------------------------------------------
>
> Key: MESOS-3872
> URL: https://issues.apache.org/jira/browse/MESOS-3872
> Project: Mesos
> Issue Type: Bug
> Components: general
> Reporter: Alex Clemmer
> Assignee: Alex Clemmer
> Labels: mesosphere, windows
>
> From the comments:
> # TODO(hausdorff): We have disabled colors for the diffs on Windows, as
> piping them through `subprocess` causes us to emit ANSI escape codes, which
> the command prompt doesn't recognize. Presumably we are being routed through
> some TTY that causes git to not emit the colors using `cmd`'s color codes API
> (which is entirely different from ANSI. See [1] for more information and
> MESOS-3872.
> #
> # [1]
> http://stackoverflow.com/questions/5921556/in-git-bash-on-windows-7-colors-display-as-code-when-running-cucumber-or-rspec
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
