[ 
https://issues.apache.org/jira/browse/MESOS-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009193#comment-15009193
 ] 

Michael Park commented on MESOS-3920:
-------------------------------------

For reference sake, the 
[review|https://reviews.apache.org/r/32982/#comment134693] where this was 
discussed briefly.

Does this change mean that we also want to change the {{/teardown}} endpoint to 
receive the {{FrameworkID}} via JSON? may also apply to maintenance endpoints? 
(I'm not challenging the proposal, just trying to understand the scope/plan as 
well as HTTP conventions in general).

> Considering changing /reserve, /unreserve endpoint syntax
> ---------------------------------------------------------
>
>                 Key: MESOS-3920
>                 URL: https://issues.apache.org/jira/browse/MESOS-3920
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Neil Conway
>            Priority: Minor
>              Labels: http, mesosphere, reservations
>
> Right now, the "reserve" and "unreserve" endpoints work as follows:
> 1. slaveID is sent as a separate query parameter
> 2. the resources to reserve are sent as the "reserve" query parameter, where 
> the value is encoded in JSON
> This is weird, for two reasons:
> 1. It is more typical for POST to send the content of the new document in the 
> request body, not as parameters to the query string (e.g., 
> https://stackoverflow.com/questions/14551194/how-are-parameters-sent-in-an-http-post-request)
> 2. It is weird to mix query parameters (slaveID, resources) with JSON-encoded 
> values. Why not just post a single JSON document with all the information 
> required for a dynamic reservation?
> Obviously, there are some backward compatibility concerns if we want to 
> change this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to