[ 
https://issues.apache.org/jira/browse/MESOS-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028154#comment-15028154
 ] 

Neil Conway commented on MESOS-3552:
------------------------------------

There's also MESOS-3990, which wouldn't be handled by either almostEqual or 
CHECK_DOUBLE_EQ: the problem in MESOS-3990 is that we return unexpected results 
to the user.

Since the plan is to switch to fixed-point anyway, personally I think we should 
focus on (a) fixing the crashing / failing CHECKs, then (b) figuring out a 
migration plan toward fixed-point resource values.

> CHECK failure due to floating point precision on reservation request
> --------------------------------------------------------------------
>
>                 Key: MESOS-3552
>                 URL: https://issues.apache.org/jira/browse/MESOS-3552
>             Project: Mesos
>          Issue Type: Task
>          Components: master
>            Reporter: Mandeep Chadha
>            Assignee: Mandeep Chadha
>              Labels: mesosphere, tech-debt
>
> result.cpus() == cpus() check is failing due to ( double == double ) 
> comparison problem. 
> Root Cause : 
> Framework requested 0.1 cpu reservation for the first task. So far so good. 
> Next Reserve operation — lead to double operations resulting in following 
> double values :
>  results.cpus() : 23.9999999999999964472863211995 cpus() : 24
> And the check ( result.cpus() == cpus() ) failed. 
>  The double arithmetic operations caused results.cpus() value to be :  
> 23.9999999999999964472863211995 and hence ( 23.9999999999999964472863211995 
> == 24 ) failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to