[ 
https://issues.apache.org/jira/browse/MESOS-4161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15073392#comment-15073392
 ] 

Jian Qiu edited comment on MESOS-4161 at 12/29/15 2:49 AM:
-----------------------------------------------------------

CommmandExecutor::reaped sleeps 1 second to avoid races. 
https://github.com/apache/mesos/blob/master/src/launcher/executor.cpp#L531
we can avoid this sleep by explicit killing the executor. 


was (Author: qiujian):
The reason to explicitly killing the executor is that CommmandExecutor::reaped 
sleeps 1 second to avoid races. 
https://github.com/apache/mesos/blob/master/src/launcher/executor.cpp#L531
we may avoid this sleep in test? 

> SlaveTest.CommandExecutorWithOverride is slow
> ---------------------------------------------
>
>                 Key: MESOS-4161
>                 URL: https://issues.apache.org/jira/browse/MESOS-4161
>             Project: Mesos
>          Issue Type: Improvement
>          Components: technical debt, test
>            Reporter: Alexander Rukletsov
>            Assignee: Jian Qiu
>            Priority: Minor
>              Labels: mesosphere, newbie++, tech-debt
>
> The {{SlaveTest.CommandExecutorWithOverride}} test takes around {{1.3s}} to 
> finish on my Mac OS 10.10.4:
> {code}
> SlaveTest.CommandExecutorWithOverride (1311 ms)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to