[
https://issues.apache.org/jira/browse/MESOS-4088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15074410#comment-15074410
]
Benjamin Hindman edited comment on MESOS-4088 at 12/29/15 11:16 PM:
--------------------------------------------------------------------
{code}
commit d5bc8de98b206843495674a6210bd76f8b24c038
Author: Joseph Wu <[email protected]>
Date: Tue Dec 29 15:01:09 2015 -0800
Update tests that use the MesosContainerizer to use ContainerLogger.
Review: https://reviews.apache.org/r/41169/
{code}
{code}
commit 17ef06d883a1771ce66fcc5301b765e0799ebeb8
Author: Joseph Wu <[email protected]>
Date: Tue Dec 29 11:25:50 2015 -0800
Add support for the ContainerLogger to the Mesos Containerizer.
Changes the `MesosContainerizer` to create and initialize the
`ContainerLogger`.
The `MesosContainerizer` modifies the arguments to `launcher->fork()`
(in `::_launch`) by calling the `ContainerLogger` beforehand.
Review: https://reviews.apache.org/r/41167/
{code}
{code}
commit ed7bfa96153958edae48bd553e0b1747328546a0
Author: Joseph Wu <[email protected]>
Date: Tue Dec 29 11:25:10 2015 -0800
Explicitly disallow ContainerLogger with the External Containerizer.
Using the `ContainerLogger` with the `ExternalContainerizer` is not
supported at the moment. We explicitly disallowed the combination, so
that there are no incorrect assumptions.
Review: https://reviews.apache.org/r/41166/
{code}
was (Author: benjaminhindman):
{code}
commit d5bc8de98b206843495674a6210bd76f8b24c038
Author: Joseph Wu <[email protected]>
Date: Tue Dec 29 15:01:09 2015 -0800
Update tests that use the MesosContainerizer to use ContainerLogger.
Review: https://reviews.apache.org/r/41169/
{code}
{code}
commit d041363f87b7c4d28df06cb96fc4fbe1189e16e4
Author: Benjamin Hindman <[email protected]>
Date: Tue Dec 29 15:01:03 2015 -0800
Cleanups in containerizer.cpp.
{code}
{code}
commit 17ef06d883a1771ce66fcc5301b765e0799ebeb8
Author: Joseph Wu <[email protected]>
Date: Tue Dec 29 11:25:50 2015 -0800
Add support for the ContainerLogger to the Mesos Containerizer.
Changes the `MesosContainerizer` to create and initialize the
`ContainerLogger`.
The `MesosContainerizer` modifies the arguments to `launcher->fork()`
(in `::_launch`) by calling the `ContainerLogger` beforehand.
Review: https://reviews.apache.org/r/41167/
{code}
{code}
commit ed7bfa96153958edae48bd553e0b1747328546a0
Author: Joseph Wu <[email protected]>
Date: Tue Dec 29 11:25:10 2015 -0800
Explicitly disallow ContainerLogger with the External Containerizer.
Using the `ContainerLogger` with the `ExternalContainerizer` is not
supported at the moment. We explicitly disallowed the combination, so
that there are no incorrect assumptions.
Review: https://reviews.apache.org/r/41166/
{code}
> Modularize existing plain-file logging for executor/task logs launched with
> the Mesos Containerizer
> ---------------------------------------------------------------------------------------------------
>
> Key: MESOS-4088
> URL: https://issues.apache.org/jira/browse/MESOS-4088
> Project: Mesos
> Issue Type: Task
> Components: modules
> Reporter: Joseph Wu
> Assignee: Joseph Wu
> Labels: logging, mesosphere
> Fix For: 0.27.0
>
>
> Once a module for executor/task output logging has been introduced, the
> default module will mirror the existing behavior. Executor/task
> stdout/stderr is piped into files within the executor's sandbox directory.
> The files are exposed in the web UI, via the {{/files}} endpoint.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
