Alex Clemmer created MESOS-4270:
-----------------------------------

             Summary: Harden the OS-version-specific Windows code to be 
resiliant to many platforms
                 Key: MESOS-4270
                 URL: https://issues.apache.org/jira/browse/MESOS-4270
             Project: Mesos
          Issue Type: Bug
          Components: libprocess
            Reporter: Alex Clemmer
            Assignee: Alex Clemmer


A good example of a place when we try to compile on other versions of Windows 
is the implementation of our symlink logic.

In order to tell whether a path points at a symlink on Windows, we have to 
query the reparse point subsystem for information, and use an API from the 
driver DK to decide whether it is a symlink.

Unfortunately, since we're not taking a dependency on the DDK here, we were 
forced to copy the struct from the DDK that we need to query the reparse point 
API for symlink data (a path well-work by Boost FS).

To make sure we don't break, we should possibly set the version info in 
windows.hpp (see: 
https://msdn.microsoft.com/en-us/library/windows/hardware/ff554695(v=vs.85).aspx)
 and then static assert on that in the reparsepoint.hpp file.


This, of course, is just one example of a thing we'd want to be resilient to.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to