[ 
https://issues.apache.org/jira/browse/MESOS-4339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093812#comment-15093812
 ] 

Fan Du commented on MESOS-4339:
-------------------------------

bq. since all the weights inside a role are identical, right?

for current implementation, yes.
it will behave just as weighted role if we add weight when adding new framework.

My understanding about current allocation behavior is a triple iteration
as following:

[HierarchicalAllocatorProcess::allocate|https://github.com/apache/mesos/blob/master/src/master/allocator/mesos/hierarchical.cpp#L1254]
* Foreach Slave in the Slaves Vector
** Foreach Role sorted by rolesorter with role weights
*** Foreach Framework sorted by frameworksorter with identical weights within 
the same role

The intention of this ticket is enable Framework sorted by weights, i.e. the 
last iteration. I think this is where we saw differently.
Please correct me if I missed somewhere else.

bq. Also, currently frameworks can only have a single role.

Yes, but temporally.
It will be changed by 
[MESOS-1763|https://issues.apache.org/jira/browse/MESOS-1763]





> Add weight support for framework sorter
> ---------------------------------------
>
>                 Key: MESOS-4339
>                 URL: https://issues.apache.org/jira/browse/MESOS-4339
>             Project: Mesos
>          Issue Type: Improvement
>          Components: allocation
>            Reporter: Fan Du
>
> Current framework sorter doesn't take into account of weights when sorting 
> framework belonging to a particular role, i.e., all frameworks has equal 
> weights as 1. Considering the role weight is controlled by the operator, 
> enable the framework weight does not impact the role level allocation 
> decision from any greedy frameworks, but it will be beneficial to some 
> framework who could get more resources within a specific role.
> The framework weight will come from message FrameworkInfo when it got 
> registered, and FrameworkSorters will "add" framework with weight,
> this will eventually result a weighted framework sorting flow when master 
> make the finally allocation decision.
> Please review this ticket which I will work on if it's considered acceptable.
> Thanks a lot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to