[ 
https://issues.apache.org/jira/browse/MESOS-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090140#comment-15090140
 ] 

Joseph Wu edited comment on MESOS-4301 at 1/14/16 9:36 PM:
-----------------------------------------------------------

While fixing this log line, found another bug.

Essentially:
# {{validation::offer::validate}} returns an error when an {{InverseOffer}} is 
accepted.
# If an {{Offer}} is part of the same {{Call::ACCEPT}}, the master sees 
{{error.isSome()}} and returns a {{TASK_LOST}} for normal offers.  
(https://github.com/apache/mesos/blob/fafbdca610d0a150b9fa9cb62d1c63cb7a6fdaf3/src/master/master.cpp#L3117)

Regression test:
https://reviews.apache.org/r/42092/ (discarded)


was (Author: kaysoky):
While fixing this log line, found another bug.

Essentially:
# {{validation::offer::validate}} returns an error when an {{InverseOffer}} is 
accepted.
# If an {{Offer}} is part of the same {{Call::ACCEPT}}, the master sees 
{{error.isSome()}} and returns a {{TASK_LOST}} for normal offers.  
(https://github.com/apache/mesos/blob/fafbdca610d0a150b9fa9cb62d1c63cb7a6fdaf3/src/master/master.cpp#L3117)

Regression test:
https://reviews.apache.org/r/42092/

> Accepting an inverse offer prints misleading logs
> -------------------------------------------------
>
>                 Key: MESOS-4301
>                 URL: https://issues.apache.org/jira/browse/MESOS-4301
>             Project: Mesos
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.25.0
>            Reporter: Joseph Wu
>            Assignee: Joseph Wu
>              Labels: log, maintenance, mesosphere
>
> Whenever a scheduler accepts an inverse offer, Mesos will print a line like 
> this in the master logs:
> {code}
> W1125 10:05:53.155109 29362 master.cpp:2897] ACCEPT call used invalid offers 
> '[ 932f7d7b-f2d4-42c7-9391-222c19b9d35b-O2 ]': Offer 
> 932f7d7b-f2d4-42c7-9391-222c19b9d35b-O2 is no longer valid
> {code}
> Inverse offers should not trigger this warning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to