[
https://issues.apache.org/jira/browse/MESOS-3838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110265#comment-15110265
]
Adam B commented on MESOS-3838:
-------------------------------
I'm not sure I see the use in this change. Who else will call
`authorizeTeardown()`? With only one caller, it seems unnecessary to extract
that logic into a separate function. As we add more and more authorization
calls, we'll probably need to refactor the authorizer so there's less
duplicated code across all the authorizing endpoints/actions.
Is this a dependency of MESOS-4154? If so, please add a "blocks"/"blocked by"
link in JIRA (see the 'More' menu above).
> Put authorize logic for teardown into a common function
> -------------------------------------------------------
>
> Key: MESOS-3838
> URL: https://issues.apache.org/jira/browse/MESOS-3838
> Project: Mesos
> Issue Type: Bug
> Reporter: Guangya Liu
> Assignee: Guangya Liu
>
> The mesos now have {{authorizeTask}}, {{authorizeFramework}} and may have
> {{authorizeReserveResource}} and {{authorizeUnReserveResource}} later.
> But now the {{Master::Http::teardown()}} is putting the authorize logic in
> the {{Master::Http::teardown()}} itself, it is better to put authorize logic
> for teardown into a common function {{authorizeTeardown()}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
