[
https://issues.apache.org/jira/browse/MESOS-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120131#comment-15120131
]
Joseph Wu edited comment on MESOS-4535 at 1/27/16 8:45 PM:
-----------------------------------------------------------
|| Review || Summary ||
| https://reviews.apache.org/r/42864/ | Change + test to subprocess |
| https://reviews.apache.org/r/42865/ | Fix for logrotate logger |
was (Author: kaysoky):
| Review | Summary |
| https://reviews.apache.org/r/42864/ | Change + test to subprocess |
| https://reviews.apache.org/r/42865/ | Fix for logrotate logger |
> Logrotate ContainerLogger may not handle FD ownership correctly
> ---------------------------------------------------------------
>
> Key: MESOS-4535
> URL: https://issues.apache.org/jira/browse/MESOS-4535
> Project: Mesos
> Issue Type: Bug
> Components: modules
> Reporter: Joseph Wu
> Assignee: Joseph Wu
> Priority: Blocker
> Labels: logging, mesosphere
>
> One of the patches for [MESOS-4136] introduced the {{FDType::OWNED}} enum for
> {{Subprocess::IO::FD}}.
> The way the logrotate module uses this is slightly incorrect:
> # The module starts a subprocess with an output {{Subprocess::PIPE()}}.
> # That pipe's FD is passed into another subprocess via
> {{Subprocess::IO::FD(pipe, IO::OWNED)}}.
> # When the second subprocess starts, the pipe's FD is closed in the parent.
> # When the first subprocess terminates, the existing code will try to close
> the pipe again. This effectively closes a random FD.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
