[
https://issues.apache.org/jira/browse/MESOS-4571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15125240#comment-15125240
]
Shuai Lin commented on MESOS-4571:
----------------------------------
The interesting thing is I found it used to be dropping the
{{StatusUpdateAcknowledgementMessage}} message, but was changed to drop
{{StatusUpdateMessage}} in [this
commit|https://github.com/apache/mesos/commit/7db25fc58ad8c3b41721a39e42869cbee0930575#diff-75233750ca6d3ecdb06e1deef83b787dR417].
[~vinodkone] could you explain it a little bit?
> SlaveRecoveryTest.RecoverStatusUpdateManager is not consistent with its
> description
> -----------------------------------------------------------------------------------
>
> Key: MESOS-4571
> URL: https://issues.apache.org/jira/browse/MESOS-4571
> Project: Mesos
> Issue Type: Improvement
> Components: tests
> Reporter: Shuai Lin
> Labels: newbie++
>
> The description is:
> {code}
> The slave is killed before the update reaches the scheduler. When the slave
> comes back up it resends the unacknowledged update"
> {code}
> But in the test code, the {{StatusUpdateMessage}} is dropped, so there is no
> checkpointing for status update involved at all. It's the executor resends
> the unacknowledged status updates when reconnecting, rather than the slave
> "resends the unacknowledged update". This means this test is the same with
> {{SlaveRecoveryTest.ReconnectExecutor}}, which doesn't make sense.
> To fix it, we should drop the {{StatusUpdateAcknowledgementMessage}} instead
> of the {{StatusUpdateMessage}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
