[ 
https://issues.apache.org/jira/browse/MESOS-4579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129099#comment-15129099
 ] 

James Peach commented on MESOS-4579:
------------------------------------

Unconditional {{-Wno-maybe-uninitialized}} seems dangerous. You could use the 
warning pragmas to scope that to just the triggering code. Seems reasonable to 
just mark this as a duplicate of MESOS-2690.

> "Uninitialized variable" warnings with "-O3" build
> --------------------------------------------------
>
>                 Key: MESOS-4579
>                 URL: https://issues.apache.org/jira/browse/MESOS-4579
>             Project: Mesos
>          Issue Type: Bug
>          Components: docker
>            Reporter: James Peach
>
> GCC 5.3 (Fedora 23)
> {code}
> ../../src/docker/docker.cpp:289:17: error: ‘*((void*)& optionalPid +4)’ may 
> be used uninitialized in this function [-Werror=maybe-uninitialized]
>    Option<pid_t> optionalPid;
>                  ^
> ../../src/docker/docker.cpp: In static member function ‘static 
> process::Future<Nothing> Docker::_stop(const Docker&, const string&, const 
> string&, const process::Subprocess&, bool)’:
> ../../src/docker/docker.cpp:710:35: error: ‘*((void*)& status +4)’ may be 
> used uninitialized in this function [-Werror=maybe-uninitialized]
>      bool force = !status.isSome() || status.get() != 0;
>                                    ^
> ../../src/docker/docker.cpp: In static member function ‘static 
> process::Future<Docker::Image> Docker::_pull(const Docker&, const 
> process::Subprocess&, const string&, const string&, const string&, const 
> string&, process::Future<std::__cxx11::basic_string<char> >)’:
> ../../src/docker/docker.cpp:1097:23: error: ‘*((void*)& status +4)’ may be 
> used uninitialized in this function [-Werror=maybe-uninitialized]
>    if (status.isSome() && status.get() == 0) {
>                        ^
> cc1plus: all warnings being treated as errors
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to