[ 
https://issues.apache.org/jira/browse/MESOS-4602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163404#comment-15163404
 ] 

Anand Mazumdar commented on MESOS-4602:
---------------------------------------

{code}
commit fd1101db8af8f3ea684a09e2f1d79f5fa9b69496
Author: Yong Tang [email protected]
Date:   Tue Feb 23 10:47:15 2016 +0100

Fixed invalid usage of ATOMIC_FLAG_INIT in libprocess.

Review: https://reviews.apache.org/r/43859/
{code}

> Invalid usage of ATOMIC_FLAG_INIT in member initialization
> ----------------------------------------------------------
>
>                 Key: MESOS-4602
>                 URL: https://issues.apache.org/jira/browse/MESOS-4602
>             Project: Mesos
>          Issue Type: Bug
>          Components: libprocess
>            Reporter: Benjamin Bannier
>            Assignee: Yong Tang
>              Labels: newbie, tech-debt
>
> MESOS-2925 fixed a few instances where {{ATOMIC_FLAG_INIT}} was used in 
> initializer lists, but missed to fix 
> {{3rdparty/libprocess/src/libevent_ssl_socket.cpp}} (even though the 
> corresponding header was touched).
> There, {{LibeventSSLSocketImpl}}'s {{lock}} member is still (incorrectly) 
> initialized in initializer lists, even though the member is already 
> initialized in the class declaration, so it appears they should be dropped.
> Clang from trunk incorrectly diagnoses the initializations in the initializer 
> lists as benign redundant braces in initialization of a scalar, but they 
> should be fixed for the reasons stated in MESOS-2925.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to