[
https://issues.apache.org/jira/browse/MESOS-4790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169870#comment-15169870
]
Neil Conway commented on MESOS-4790:
------------------------------------
We can probably mark most of those {{constexpr}}, also.
> Revert external linkage of symbols in master/constants.hpp
> ----------------------------------------------------------
>
> Key: MESOS-4790
> URL: https://issues.apache.org/jira/browse/MESOS-4790
> Project: Mesos
> Issue Type: Improvement
> Components: master
> Reporter: Neil Conway
> Priority: Trivial
> Labels: mesosphere, newbie, tech-debt
>
> src/master/constants.hpp contains:
> {code}
> // TODO(bmahler): It appears there may be a bug with gcc-4.1.2 in which the
> // duration constants were not being initialized when having static linkage.
> // This issue did not manifest in newer gcc's. Specifically, 4.2.1 was ok.
> // So we've moved these to have external linkage but perhaps in the future
> // we can revert this.
> {code}
> From commit 232a23b2a2e11f4e905b834aa2a11afe5bf6438a. We should investigate
> whether this is still necessary on supported compilers; it likely is not.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
