[
https://issues.apache.org/jira/browse/MESOS-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184905#comment-15184905
]
Travis Hegner commented on MESOS-4370:
--------------------------------------
Here is the latest comment on the review for this patch (but spell checked now
:/): https://reviews.apache.org/r/43093/
I think I understand the miscommunication better now. As you know, beginning
with docker 1.9 the docker inspect output changed the location of the
IPAddress. The original location was still populated for backwards
compatibility, but only for the common "bridge" and "host" network types. Mesos
is written to fail with any other network type. With the new user defined
networks feature, the old location was not populated. My patch was originally
intended to address the fact that with user defined networks, the original ip
location was null.
In order to utilize user defined networks in my environment, we are passing
arbitrary docker parameters to mesos with the docker containerizer from
marathon. This results in multiple "--net" parameters passed to docker. The
luck comes into play because mesos interprets the first --net parameter of
"bridge" and succeeds, and docker interprets the second --net parameter of my
UDN, and connects to the right network. I would consider this behavior unstable
at best.
Based on the sudden up-tick in interest in this patch, I am speculating that
docker 1.10 is no longer populating the original ip address field (I would be
un-aware, because I've been running my cluster with this patch), which this
patch will successfully fix, and even be stable for the typical "host" and
"bridge" networks.
All that said, I can see why this patch is now more important, even though it
should be re-structured after review 42516 is implemented. I'll see if I can
spend some time today and address the remaining issues with this patch.
> NetworkSettings.IPAddress field is deprecated in Docker
> -------------------------------------------------------
>
> Key: MESOS-4370
> URL: https://issues.apache.org/jira/browse/MESOS-4370
> Project: Mesos
> Issue Type: Bug
> Components: containerization, docker
> Affects Versions: 0.25.0, 0.26.0, 0.27.0
> Environment: Ubuntu 14.04
> Docker 1.9.1
> Reporter: Clint Armstrong
> Assignee: Travis Hegner
>
> The latest docker API deprecates the NetworkSettings.IPAddress field, in
> favor of the NetworkSettings.Networks field.
> https://docs.docker.com/engine/reference/api/docker_remote_api/#v1-21-api-changes
> With this deprecation, NetworkSettings.IPAddress is not populated for
> containers running with networks that use new network plugins.
> As a result the mesos API has no data in
> container_status.network_infos.ip_address or
> container_status.network_infos.ipaddresses.
> The immediate impact of this is that mesos-dns is unable to retrieve a
> containers IP from the netinfo interface.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
