[ 
https://issues.apache.org/jira/browse/MESOS-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196404#comment-15196404
 ] 

Cody Maloney commented on MESOS-2281:
-------------------------------------

The JSON format was added as part of MESOS-1391. The original author intended 
to deprecate the legacy credential format.

Original commit: 
https://github.com/apache/mesos/commit/2cb3761c6bfa80b956eaafde9c69eafaeac3deae
Review:
https://reviews.apache.org/r/22222/

The JSON format should allow us to eliminate some code, as well as provide a 
more robust parser to ensure people don't read / write garbage (There was 
accidentally a newline or space added to the name of one principal, now all the 
parsing is off by a little bit and things aren't working properly)

> Deprecate plain text Credential format.
> ---------------------------------------
>
>                 Key: MESOS-2281
>                 URL: https://issues.apache.org/jira/browse/MESOS-2281
>             Project: Mesos
>          Issue Type: Improvement
>          Components: master, slave
>    Affects Versions: 0.21.1
>            Reporter: Cody Maloney
>            Assignee: Jan Schlicht
>              Labels: mesosphere, security, tech-debt
>
> Currently two formats of credentials are supported: JSON
> {code}
>   "credentials": [
>     {
>       "principal": "sherman",
>       "secret": "kitesurf"
>     }
> {code}
> And a new line file:
> {code}
> principal1 secret1
> pricipal2 secret2
> {code}
> We should deprecate the new line format and remove support for the old format.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to