[
https://issues.apache.org/jira/browse/MESOS-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201174#comment-15201174
]
Klaus Ma commented on MESOS-4976:
---------------------------------
It seems we need to add checking in {{Resources::apply}}.
{code}
@1006,6 +1006,8 @@ Try<Resources> Resources::apply(const Offer::Operation&
operation) const
return Error("Invalid UNRESERVE Operation: Resource is not
reserved");
} else if (!reserved.has_reservation()) {
return Error("Invalid UNRESERVE Operation: Missing 'reservation'");
+ } else if (Resources::isRevocable(reserved)) {
+ return Error("Invalid UNRESERVE Operation: Resource is revocable");
}
if (!result.contains(reserved)) {
{code}
> Reject RESERVE on revocable resources
> -------------------------------------
>
> Key: MESOS-4976
> URL: https://issues.apache.org/jira/browse/MESOS-4976
> Project: Mesos
> Issue Type: Bug
> Components: master
> Reporter: Klaus Ma
>
> In {{Resources::apply}}, we did not check whether the resources is revocable
> or not. It does not make sense to reserve a revocable resources.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
