Neil Conway created MESOS-4993:
----------------------------------

             Summary: FetcherTest.ExtractZipFile assumes `unzip` is installed
                 Key: MESOS-4993
                 URL: https://issues.apache.org/jira/browse/MESOS-4993
             Project: Mesos
          Issue Type: Task
          Components: fetcher, tests
            Reporter: Neil Conway


{noformat}
[ RUN      ] FetcherTest.ExtractZipFile
W0322 06:46:42.086458  3635 fetcher.cpp:805] Begin fetcher log (stderr in 
sandbox) for container b71f9a05-9561-402a-b33a-c9dc4f8b03cc from running 
command: /home/vagrant/build-mesos-2/src/mesos-fetcher
I0322 06:46:41.895934  3653 fetcher.cpp:424] Fetcher Info: 
{"cache_directory":"\/tmp\/mesos\/fetch\/slaves\/","items":[{"action":"BYPASS_CACHE","uri":{"extract":true,"value":"\/tmp\/0OaVy1\/from\/yMUPVR.zip"}}],"sandbox_directory":"\/tmp\/0OaVy1"}
I0322 06:46:41.896709  3653 fetcher.cpp:379] Fetching URI 
'/tmp/0OaVy1/from/yMUPVR.zip'
I0322 06:46:41.896719  3653 fetcher.cpp:250] Fetching directly into the sandbox 
directory
I0322 06:46:41.896729  3653 fetcher.cpp:187] Fetching URI 
'/tmp/0OaVy1/from/yMUPVR.zip'
I0322 06:46:41.896738  3653 fetcher.cpp:167] Copying resource with command:cp 
'/tmp/0OaVy1/from/yMUPVR.zip' '/tmp/0OaVy1/yMUPVR.zip'
I0322 06:46:41.899859  3653 fetcher.cpp:84] Extracting with command: unzip -o 
-d '/tmp/0OaVy1' '/tmp/0OaVy1/yMUPVR.zip'
sh: unzip: command not found
Failed to fetch '/tmp/0OaVy1/from/yMUPVR.zip': Failed to extract: command unzip 
-o -d '/tmp/0OaVy1' '/tmp/0OaVy1/yMUPVR.zip' exited with status: 32512

End fetcher log for container b71f9a05-9561-402a-b33a-c9dc4f8b03cc
E0322 06:46:42.087045  3635 fetcher.cpp:520] Failed to run mesos-fetcher: 
Failed to fetch all URIs for container 'b71f9a05-9561-402a-b33a-c9dc4f8b03cc' 
with exit status: 256
/mesos-2/src/tests/fetcher_tests.cpp:688: Failure
(fetch).failure(): Failed to fetch all URIs for container 
'b71f9a05-9561-402a-b33a-c9dc4f8b03cc' with exit status: 256
[  FAILED  ] FetcherTest.ExtractZipFile (227 ms)
[----------] 1 test from FetcherTest (227 ms total)
{noformat}

Similarly:

{noformat}
[  FAILED  ] FetcherTest.ExtractZipFile
[  FAILED  ] FetcherTest.ExtractInvalidZipFile
[  FAILED  ] FetcherTest.ExtractZipFileWithDuplicatedEntries
{noformat}

We should handle missing {{unzip}} more gracefully, e.g., skip the test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to