[
https://issues.apache.org/jira/browse/MESOS-5049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214464#comment-15214464
]
Joerg Schad edited comment on MESOS-5049 at 3/28/16 5:00 PM:
-------------------------------------------------------------
{noformat}
commit f8364bb45b651a1721985cf9ca9099eeaca0461f
Author: Joerg Schad [email protected]
Date: Mon Mar 28 16:52:00 2016 +0200
Subprocess: [1/7] Refactored setup functions.
Executing arbitrary setup functions while creating new processes is
dangerous as all functions called have to be async safe. As setup
functions are used for only very few purposes (setsid, chdir, monitoring
and killing a process (see upcoming review) it makes sense to support
them safely via parameters to subprocess. Note this review by itself
\-without the following ones- removing the uses of the old interface
will break the build.
Review: https://reviews.apache.org/r/45230/
commit 5043f0d63425c29d4013c71d04a57ade25fe6996
Author: Joerg Schad [email protected]
Date: Mon Mar 28 17:00:22 2016 +0200
Subprocess: [2/7] Removed the use of setup functions.
This review follows the previous one and removes most
(see following reviews) usages setup functions throughout
the code.
Review: https://reviews.apache.org/r/45231/
commit a3d1bd49a3456c4be19292293f5bd2c76ac46632
Author: Joerg Schad [email protected]
Date: Mon Mar 28 17:02:06 2016 +0200
Subprocess: [3/7] Introduced watchdog option.
Some newly created processes such as perf should be killed in case the
parent dies. Currently this is achieved by forking a new process from
the child process which serves as a 'watchdog' and kill the child if the
parent dies. This review introduces this as a general behavior into
subprocess (and hence removes the need for the custom setup function).
Review: https://reviews.apache.org/r/45232/
commit dbddb6bd4dafebb46efe64cf3c2424390bbcff6b
Author: Joerg Schad [email protected]
Date: Mon Mar 28 17:02:12 2016 +0200
Subprocess: [4/7] Refactored perf test without setup function.
With the newly introduced watchdog option there is no need
for the child setup function in the perf code anymore.
Review: https://reviews.apache.org/r/45233/
commit 85f6145e5ea34c2574e07ec97413a7010e76befe
Author: Joerg Schad [email protected]
Date: Mon Mar 28 17:02:18 2016 +0200
Subprocess: [5/7] Introduced parentHooks to fork calls.
So far subprocess supports parentHooks. This review adds this option
also to fork().
Review: https://reviews.apache.org/r/45235/
commit 0e2895c744ea2ae19ae72c2597862efefe0c2479
Author: Joerg Schad [email protected]
Date: Mon Mar 28 17:02:23 2016 +0200
Subprocess: [6/7] Refactored isolator tests to use parentHook.
The isolator tests parent process isolates the child while the child
is being blocked. This this the exact patter of a parentHook.
Review: https://reviews.apache.org/r/45236/
commit 5914f571ea569777c8bda497a3eb1e6878ea8eb5
Author: Joerg Schad [email protected]
Date: Mon Mar 28 17:35:19 2016 +0200
Subprocess: [7/7] Added watchdog to 'du' disk isolator process.
The disk isolator process should also be killed when
the parent process dies.
Review: https://reviews.apache.org/r/45245/
{noformat}
was (Author: js84):
'''commit 5914f571ea569777c8bda497a3eb1e6878ea8eb5
Author: Joerg Schad [email protected]
Date: Mon Mar 28 17:35:19 2016 +0200
Subprocess: [7/7] Added watchdog to 'du' disk isolator process.
The disk isolator process should also be killed when
the parent process dies.
Review: https://reviews.apache.org/r/45245/
'''
> Refactore subproces setup functions.
> ------------------------------------
>
> Key: MESOS-5049
> URL: https://issues.apache.org/jira/browse/MESOS-5049
> Project: Mesos
> Issue Type: Improvement
> Reporter: Joerg Schad
> Assignee: Joerg Schad
>
> Executing arbitrary setup functions while creating new processes is
> dangerous as all functions called have to be async safe. As setup
> functions are used for only very few purposes (setsid, chdir, monitoring
> and killing a process (see upcoming review) it makes sense to support
> them safely via parameters to subprocess.
> Another common use of child setup are is to block the child while doing some
> work in the parent. This pattern can be more cleanly expressed with
> parentHooks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
