[
https://issues.apache.org/jira/browse/MESOS-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220703#comment-15220703
]
ASF GitHub Bot commented on MESOS-1797:
---------------------------------------
Github user chenzhiwei commented on a diff in the pull request:
https://github.com/apache/mesos/pull/93#discussion_r58131254
--- Diff: 3rdparty/Makefile.am ---
@@ -51,7 +51,7 @@ EXTRA_DIST = \
EXTRA_DIST += \
$(LEVELDB).patch
-# We need to patch ZooKeeper in order to get 3.4.5 to compile on
+# We need to patch ZooKeeper in order to get 3.4.8 to compile on
# OS X 10.10. See: MESOS-1797.
--- End diff --
Thank your for pointing this, I will remove this comment. And for the
zookeeper patch file I think I already removed it.
> Packaged Zookeeper does not compile on OSX Yosemite
> ---------------------------------------------------
>
> Key: MESOS-1797
> URL: https://issues.apache.org/jira/browse/MESOS-1797
> Project: Mesos
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.19.1, 0.20.0, 0.21.0
> Reporter: Dario Rexin
> Assignee: Benjamin Mahler
> Priority: Minor
> Fix For: 0.21.0
>
>
> I have been struggling with this for some time (due to my lack of knowledge
> about C compiler error messages) and finally found a way to make it compile.
> The problem is that Zookeeper defines a function `htonll` that is a builtin
> function in Yosemite. For me it worked to just remove this function, but as
> it needs to keep working on other systems as well, we would need some check
> for the OS version or if the function is already defined.
> Here are the links to the source:
> https://github.com/apache/zookeeper/blob/trunk/src/c/include/recordio.h#L73
> https://github.com/apache/zookeeper/blob/trunk/src/c/src/recordio.c#L83-L97
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
