[
https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239680#comment-15239680
]
Kevin Klues commented on MESOS-3782:
------------------------------------
I've given "Ship it!" to both of the patches above. My testing was as follows:
{noformat}
cd mesos
/support/apply-reviews.py -c -r 46134
./bootstrap
rm -rf build && mkdir build
cd build
../configure --prefix=${HOME}/install/mesos
make -j
make check
make install
{noformat}
After verifying that the above procedure worked, I grepped the code base for
any instances of "mesos-slave" and verified that they only existed in the
`docs` folder, the `webui`, and in files touched as part of this ticket (the
docs and webui changes are covered by other tickets)
I then inspected the location of the installed binaries at
`$HOME/install/mesos` and verified that all scripts/binaries named
"mesos-slave*" are duplicated as "mesos-agent*".
{noformat}
klueska@c99:~/install/mesos$ find . -name "*slave*" | grep -v webui
./sbin/mesos-stop-slaves.sh
./sbin/mesos-start-slaves.sh
./sbin/mesos-slave
./etc/mesos/mesos-slave-env.sh.template
./include/mesos/slave
klueska@c99:~/install/mesos$ find . -name "*agent*"
./sbin/mesos-stop-agents.sh
./sbin/mesos-agent
./sbin/mesos-start-agents.sh
./etc/mesos/mesos-agent-env.sh.template
{noformat}
The only odd man out is the `./include/mesos/slave` folder, which we've decided
to create a new ticket for dealing with (i.e. we should copy this folder to
`./include/mesos/agent` as part of the install process).
Given that, everything looks good from my end!
> Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create
> symlinks)
> --------------------------------------------------------------------------------------
>
> Key: MESOS-3782
> URL: https://issues.apache.org/jira/browse/MESOS-3782
> Project: Mesos
> Issue Type: Task
> Reporter: Diana Arroyo
> Assignee: zhou xing
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
