[
https://issues.apache.org/jira/browse/MESOS-5305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anand Mazumdar updated MESOS-5305:
----------------------------------
Description:
Extra warnings can be enabled with `-Wextra` in gcc or clang. This does not
affect functionality, but just as a noise when building mesos, or just a style
issue in Cmake build.
E.g.,
https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp#L327
the `separator` parameter name can be either omitted or commented out.
another example,
https://github.com/apache/mesos/blob/master/include/mesos/slave/isolator.hpp#L84
the `containerId` parameter name.
All similar issues should be fixed together. It won't be a bad idea to build
Mesos with {{-Wextra}} enabled.
was:
Extra warnings can be enabled with `-Wextra` in gcc or clang. This does not
affect functionality, but just as a noise when building mesos, or just a style
issue in Cmake build.
E.g.,
https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp#L327
the `separator` parameter name can be either omitted or commented out.
another example,
https://github.com/apache/mesos/blob/master/include/mesos/slave/isolator.hpp#L84
the `containerId` parameter name.
All similar issues should be fixed together.
> 'unused parameter' warnings may occur when '-Wextra' is enabled.
> ----------------------------------------------------------------
>
> Key: MESOS-5305
> URL: https://issues.apache.org/jira/browse/MESOS-5305
> Project: Mesos
> Issue Type: Bug
> Environment: gcc, clang
> Reporter: Gilbert Song
> Priority: Trivial
> Labels: build, newbie, newbie++
>
> Extra warnings can be enabled with `-Wextra` in gcc or clang. This does not
> affect functionality, but just as a noise when building mesos, or just a
> style issue in Cmake build.
> E.g.,
> https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp#L327
> the `separator` parameter name can be either omitted or commented out.
> another example,
> https://github.com/apache/mesos/blob/master/include/mesos/slave/isolator.hpp#L84
> the `containerId` parameter name.
> All similar issues should be fixed together. It won't be a bad idea to build
> Mesos with {{-Wextra}} enabled.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
