[
https://issues.apache.org/jira/browse/MESOS-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15281855#comment-15281855
]
Yan Xu commented on MESOS-5279:
-------------------------------
So in the reviews activate and add are treated differently:
- {{activate}} is made idempotent, if you activate the client which is already
active, it's OK to say this is a no-op.
- {{add}} doesn't allow adding a client already in the sorter because it has
another argument {{weight}} which could be different.
> DRF sorter add/activate doesn't check if it's adding a duplicate entry
> ----------------------------------------------------------------------
>
> Key: MESOS-5279
> URL: https://issues.apache.org/jira/browse/MESOS-5279
> Project: Mesos
> Issue Type: Bug
> Components: allocation
> Reporter: Yan Xu
> Assignee: Yan Xu
>
> Currently the sorter relies on the caller to make sure the sorter is in a
> good state when add/activate is called. It's not defensive against caller
> mistakes as it should be. It's never an acceptable result if duplicates are
> added to {{DRFSorter::clients}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
