[
https://issues.apache.org/jira/browse/MESOS-5371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15282908#comment-15282908
]
Joris Van Remoortere commented on MESOS-5371:
---------------------------------------------
{code}
commit 4c6162d5e3535f4611e869e143c91454033dca2d
Author: Alex Clemmer <[email protected]>
Date: Fri May 13 13:25:57 2016 -0400
Windows: Added stub implementations of `fcntl.hpp` functions.
This commit introduces temporary versions of 2 important functions:
`os::nonblock` and `os::cloexec`. We put them here in a placeholder
commit so that reviewers can make progress on subprocess. In the
immediate term, the plan is to figure out on a callsite-by-callsite
basis how to work around the functionality of `os::cloexec`. When we
collect more data, we will be in a better position to offer a way
forward here.
Review: https://reviews.apache.org/r/46392/
{code}
> Implement `fcntl.hpp`
> ---------------------
>
> Key: MESOS-5371
> URL: https://issues.apache.org/jira/browse/MESOS-5371
> Project: Mesos
> Issue Type: Bug
> Components: stout
> Reporter: Alex Clemmer
> Assignee: Alex Clemmer
> Labels: mesosphere, stout, windows-mvp
>
> `fcntl.hpp` has a bunch of functions that will never work on Windows. We will
> need to work around them, either by working around specific call sites of
> functions like `os::cloexec`, or by implementing something that keeps track
> of which file descriptors are cloexec, and which aren't.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
