[
https://issues.apache.org/jira/browse/MESOS-5371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Clemmer updated MESOS-5371:
--------------------------------
Description:
`fcntl.hpp` has a bunch of functions that will never work on Windows. We will
need to work around them, either by working around specific call sites of
functions like `os::cloexec`, or by implementing something that keeps track of
which file descriptors are cloexec, and which aren't.
NOTE: We have elected to log warnings for these functions when we call them, so
that it is obvious they have done nothing. This carries a performance penalty
especially for the master, and when we resolve this issue, it is important we
remove the logging as well.
was:`fcntl.hpp` has a bunch of functions that will never work on Windows. We
will need to work around them, either by working around specific call sites of
functions like `os::cloexec`, or by implementing something that keeps track of
which file descriptors are cloexec, and which aren't.
> Implement `fcntl.hpp`
> ---------------------
>
> Key: MESOS-5371
> URL: https://issues.apache.org/jira/browse/MESOS-5371
> Project: Mesos
> Issue Type: Bug
> Components: stout
> Reporter: Alex Clemmer
> Assignee: Alex Clemmer
> Labels: mesosphere, stout, windows-mvp
>
> `fcntl.hpp` has a bunch of functions that will never work on Windows. We will
> need to work around them, either by working around specific call sites of
> functions like `os::cloexec`, or by implementing something that keeps track
> of which file descriptors are cloexec, and which aren't.
> NOTE: We have elected to log warnings for these functions when we call them,
> so that it is obvious they have done nothing. This carries a performance
> penalty especially for the master, and when we resolve this issue, it is
> important we remove the logging as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
