[ 
https://issues.apache.org/jira/browse/MESOS-5075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221526#comment-15221526
 ] 

haosdent edited comment on MESOS-5075 at 6/19/16 10:54 AM:
-----------------------------------------------------------

Patch: https://reviews.apache.org/r/43284/
| Wait for process:reap in CGROUPS_ROOT_PerfRollForward. | 
https://reviews.apache.org/r/46300/ |
| Wait for process:reap in PerfEventIsolatorTest.ROOT_CGROUPS_Sample. | 
https://reviews.apache.org/r/43284/ |


was (Author: haosd...@gmail.com):
Patch: https://reviews.apache.org/r/43284/

> Remain processes when running perf event related test cases
> -----------------------------------------------------------
>
>                 Key: MESOS-5075
>                 URL: https://issues.apache.org/jira/browse/MESOS-5075
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: haosdent
>            Assignee: haosdent
>              Labels: isolation, perf
>
> Currently when running single perf event related test cases, I always saw
> {code}
> [----------] Global test environment tear-down
> ../../src/tests/environment.cpp:790: Failure
> Failed
> Tests completed with child processes remaining:
> -+- 22886 /home/haosdent/mesos/build/src/.libs/mesos-tests 
> --gtest_filter=CgroupsIsolatorTest.ROOT_CGROUPS_PerfEventSubsystemSample 
> --verbose
>  \-+- 22963 /home/haosdent/mesos/build/src/.libs/mesos-tests 
> --gtest_filter=CgroupsIsolatorTest.ROOT_CGROUPS_PerfEventSubsystemSample 
> --verbose
>    \-+- 22965 perf stat --all-cpus --field-separator , --log-fd 1 --event 
> cycles --cgroup mesos/5f02f820-cc63-471b-98b9-37bbc4fde674 --event task-clock 
> --cgroup mesos/5f02f820-cc63-471b-98b9-37bbc4fde674 -- sleep 0.25
>      \--- 22966 sleep 0.25
> [==========] 1 test from 1 test case ran. (3165 ms total)
> {code}
> In {{PerfEventIsolatorTest.ROOT_CGROUPS_Sample}}, we add a sleep.
> {code}
> sleep(2);
> {code}
> This could avoid the remain processes in most cases, but a better approach is 
> to discard and kill perf sample process before exit.
> As discussion in [r43284 | https://reviews.apache.org/r/43284/], discard 
> did't work as well except waiting for process exit. So need to investigate 
> why discard didn't work and fix it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to