[
https://issues.apache.org/jira/browse/MESOS-5661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15340098#comment-15340098
]
haosdent commented on MESOS-5661:
---------------------------------
Looks like only {{modulesDir}} not match snake style via grep {{add(&Flags::}}.
I think could follow
{code}
add(&Flags::agent_subsystems,
"agent_subsystems",
flags::DeprecatedName("slave_subsystems"),
{code}
to deprecated {{modulesDir}} and use {{modules_dir}} instead.
> Use snake casing for flag names consistently
> --------------------------------------------
>
> Key: MESOS-5661
> URL: https://issues.apache.org/jira/browse/MESOS-5661
> Project: Mesos
> Issue Type: Improvement
> Reporter: Anand Mazumdar
> Labels: flags, mesosphere, newbie
>
> Historically, we have always used snake casing for the flag variables e.g.,
> {{docker_config}} etc. However, there are some instances in our .cpp code
> where we define the flag name in the .cpp file in camel case e.g.,
> {{modulesDir}} but still have the flag name as {{modules_dir}} when taking
> arguments from the user. It would be good to audit all such occurrences and
> consistently uses snake casing in our .cpp/.hpp files everywhere.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
