[ 
https://issues.apache.org/jira/browse/MESOS-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351993#comment-15351993
 ] 

Michael Park commented on MESOS-3243:
-------------------------------------

{noformat}
commit 470c6cc19011728b81e133a75957b1d47090504f
Author: Tomasz Janiszewski [email protected]
Date:   Mon Jun 27 15:24:23 2016 +0200

Updated support/cpplint.patch.

Generated `support/cpplint.patch` using following command:

```
PATCH="support/cpplint.patch"
FIRST_COMMIT=\`git log --pretty=format:"%h"  --diff-filter=A -- $PATCH\`
git diff ${FIRST_COMMIT}..master  support/cpplint.py > $PATCH
sed -i 's/\[ \\t\]\*$//' "$PATCH"
```

Review: https://reviews.apache.org/r/48728/
{noformat}
{noformat}
commit 6a04428f24a07e86dcee8cff66d9536c6d6dfc18
Author: Tomasz Janiszewski [email protected]
Date:   Mon Jun 27 15:24:34 2016 +0200

Update C++ style checker to prevent `NULL` usage.

Review: https://reviews.apache.org/r/48320/
{noformat}

> Replace NULL with nullptr
> -------------------------
>
>                 Key: MESOS-3243
>                 URL: https://issues.apache.org/jira/browse/MESOS-3243
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Michael Park
>            Assignee: Tomasz Janiszewski
>             Fix For: 1.0.0
>
>
> As part of the C++ upgrade, it would be nice to move our use of {{NULL}} over 
> to use {{nullptr}}. I think it would be an interesting exercise to do this 
> with {{clang-modernize}} using the [nullptr 
> transform|http://clang.llvm.org/extra/UseNullptrTransform.html] (although 
> it's probably just as easy to use {{sed}}).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to