Jie Yu created MESOS-5807:
-----------------------------

             Summary: Support job_object in subprocess on Windows.
                 Key: MESOS-5807
                 URL: https://issues.apache.org/jira/browse/MESOS-5807
             Project: Mesos
          Issue Type: Improvement
            Reporter: Jie Yu


Currently, in command executor, we use different code path for posix and 
windows:
{noformat}
#ifndef __WINDOWS__
    pid = launchTaskPosix(
        command,
        launcherDir,
        user,
        rootfs,
        sandboxDirectory,
        workingDirectory);
#else
    // A Windows process is started using the `CREATE_SUSPENDED` flag
    // and is part of a job object. While the process handle is kept
    // open the reap function will work.
    PROCESS_INFORMATION processInformation = launchTaskWindows(
        command,
        rootfs);

    pid = processInformation.dwProcessId;
    ::ResumeThread(processInformation.hThread);
    CloseHandle(processInformation.hThread);
    processHandle = processInformation.hProcess;
#endif
{noformat}

During a recent refactor (MESOS-5753), for the posix path, command executor 
reused `mesos-containerizer launch` helper to launch user tasks.

If we were to be able to support job_object in Subprocess, we can get rid of 
this divergence in command executor. This also allow us to support custom 
executors on Windows.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to