[
https://issues.apache.org/jira/browse/MESOS-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368312#comment-15368312
]
Michael Park commented on MESOS-5428:
-------------------------------------
{noformat}
commit 028480bece8984689b5535f6176d71c128cddcc2
Author: Daniel Pravat <[email protected]>
Date: Mon May 23 15:12:48 2016 -0700
Windows: Allowed `dynamic_cast` on an object being constructed.
Review: https://reviews.apache.org/r/47671/
{noformat}
> Update the mechanism to define flags in FlagsBase derived clases
> ----------------------------------------------------------------
>
> Key: MESOS-5428
> URL: https://issues.apache.org/jira/browse/MESOS-5428
> Project: Mesos
> Issue Type: Bug
> Reporter: Daniel Pravat
>
> If a program exeposes flags, the recommendation from Mesos was to use a
> derived class from FlagsBase, add the new flags in constructor.
> As benefit the new `Flags` class `inherits` all the flags from the derived
> classes.
> Each derived calss calls the method `add` implemented in `FlagsBase` which
> uses `dynamic_cast` to set the default value and other things.
> To use `FlagsBase` derived classes in Visual Studio we should disable
> construction displacements using `/vd2` compile option.
> More info: https://msdn.microsoft.com/en-us/library/7sf3txa8.aspx
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
