[ 
https://issues.apache.org/jira/browse/MESOS-5465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368742#comment-15368742
 ] 

Gilbert Song commented on MESOS-5465:
-------------------------------------

Understand your proposal. You want to modify the rootfs a little bit to include 
the manifest file. It is a solution, but just seems a liitle not ideal to me, 
since the container can do anything in its rootfs, include erasing any file on 
purpose or by some other behavior. We may not want to make any change to the 
rootfs.

I am  currently thinking handle the manifest in diff cases. If the container 
path is a relative path, we can just write it to the sandbox. If it is the an 
absolute path, we need to do a --ready-only mount as a special case. This would 
include some refactoring in our code. A discussion is absolutely welcome.


> Container image as a volume source should also include image manifest.
> ----------------------------------------------------------------------
>
>                 Key: MESOS-5465
>                 URL: https://issues.apache.org/jira/browse/MESOS-5465
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Jie Yu
>            Assignee: Guangya Liu
>
> Currently, if a user specifies the source of a volume to be an image (e.g., 
> Docker image), we only prepare the rootfs and mount it at 'container_path' in 
> the container.
> However, the rootfs itself is not sufficient to allow the executor to launch 
> the docker container. We need the docker manifest as well to get the env, 
> entry point, cmd information.
> One solutions is to make container_path a directory containing two things: 1) 
> rootfs, 2) manifest. But this is a breaking change, we might need to 
> introduce a deprecation cycle for that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to