[ 
https://issues.apache.org/jira/browse/MESOS-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374570#comment-15374570
 ] 

Yan Xu commented on MESOS-4558:
-------------------------------

Looking at the [parameterization of allocator 
benchmarks|https://github.com/apache/mesos/blob/c40e48897f05c130427758d75e593a793c7f47ae/src/tests/hierarchical_allocator_tests.cpp#L3276-L3284],
 I feel that we don't possibly need all combinations of these 
frameworkCount/agentCount numbers on ASF CI. We need a selective few which are 
representative. When I run the test I would typically filter it like 
{{SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.SuppressOffers/10}},
 can we configure ASF CI to only run a subset of parameter combinations?

The downside of this is when we add new tests we need to reconfigure ASF CI to 
select what we run. Alternatively we could establish a convention to name 
benchmarks that we would like to run on CI (ASF or not) as part of *acceptance 
testing* so we can just filter on the convention. Notice the 
{{SlaveAndFrameworkCount}} in the example is an instantiation name which could 
be used for the name convention. This makes more sense to me because the reason 
you want to run some benchmarks on CI is to automate a form a performance 
acceptance test: its scope is narrower than "all benchmarks" so additional 
filtering is applied.

e.g., we can do this
{code}
MESOS_BENCHMARK=1 GTEST_FILTER="*CI_*BENCHMARK*" make check
{code}



> Reduce the running time of benchmark tests.
> -------------------------------------------
>
>                 Key: MESOS-4558
>                 URL: https://issues.apache.org/jira/browse/MESOS-4558
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Vinod Kone
>              Labels: newbie++
>
> Currently benchmark tests take a long time (>5 hours). It would be nice to 
> reduce the total time taken by the benchmark tests to enable us to run them 
> on ASF CI.
> Command to run only benchmark tests
> {code}
> MESOS_BENCHMARK=1 GTEST_FILTER="*BENCHMARK*" make check
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to