[ 
https://issues.apache.org/jira/browse/MESOS-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375650#comment-15375650
 ] 

Benjamin Bannier commented on MESOS-5841:
-----------------------------------------

Note that we'll likely remove half of the existing overloads with MESOS-3335 as 
they can easily be misused and lead to undefined behavior.

> Clean up `FlagsBase::add`
> -------------------------
>
>                 Key: MESOS-5841
>                 URL: https://issues.apache.org/jira/browse/MESOS-5841
>             Project: Mesos
>          Issue Type: Improvement
>          Components: stout
>    Affects Versions: 1.0.0
>            Reporter: Greg Mann
>              Labels: mesosphere
>
> In the definition for {{FlagsBase}}, we currently have 20 overloads for the 
> {{FlagsBase::add}} function. This makes both the {{FlagsBase}} class 
> definition and the {{flags.cpp}} files in Mesos difficult to read. We should 
> clean up {{FlagsBase::add}} so that it does not require so many overloads.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to